Hi, On 10/26/21 21:08, Mario Limonciello wrote: > An upcoming change to platform profiles will export `platform_profile_get` > as a symbol that can be used by other drivers. Avoid the collision. > > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/hp-wmi.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c > index 8e31ffadf894..48a46466f086 100644 > --- a/drivers/platform/x86/hp-wmi.c > +++ b/drivers/platform/x86/hp-wmi.c > @@ -1061,8 +1061,8 @@ static int thermal_profile_set(int thermal_profile) > sizeof(thermal_profile), 0); > } > > -static int platform_profile_get(struct platform_profile_handler *pprof, > - enum platform_profile_option *profile) > +static int hp_wmi_platform_profile_get(struct platform_profile_handler *pprof, > + enum platform_profile_option *profile) > { > int tp; > > @@ -1087,8 +1087,8 @@ static int platform_profile_get(struct platform_profile_handler *pprof, > return 0; > } > > -static int platform_profile_set(struct platform_profile_handler *pprof, > - enum platform_profile_option profile) > +static int hp_wmi_platform_profile_set(struct platform_profile_handler *pprof, > + enum platform_profile_option profile) > { > int err, tp; > > @@ -1147,8 +1147,8 @@ static int thermal_profile_setup(void) > if (err) > return err; > > - platform_profile_handler.profile_get = platform_profile_get; > - platform_profile_handler.profile_set = platform_profile_set; > + platform_profile_handler.profile_get = hp_wmi_platform_profile_get; > + platform_profile_handler.profile_set = hp_wmi_platform_profile_set; > } > > set_bit(PLATFORM_PROFILE_COOL, platform_profile_handler.choices); >