On Wed, Oct 27, 2021 at 3:51 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Hi Mario, > > On 10/26/21 21:08, Mario Limonciello wrote: > > Currently only one driver can register as a handler for a platform profile. > > > > This limitation means that if multiple drivers want to react to platform > > profile changes that they will need to directly interact with individual > > drivers. > > > > Instead introduce a notification flow that drivers can register for event > > changes. The idea is that any driver that wants to can: > > 1. read the current profile > > 2. set up initial values > > 3. register for changes > > 4. react to changes > > > > Changes from v3->v4: > > * Simplify platform_profile_notify > > - No need to check cur_profile as platform_profile_get does it > > - No need to track ret as it's unused > > Changes from v2->v3: > > * Add patches to avoid collisions in hp-wmi and asus-wmi symbols > > We typically do not merge new in-kernel API without at least one > consumer of that in-kernel API. > > I can take patches 1 + 2 now as prep work for the future, > but I would expect Rafael to only want to take patch 3/3 if > you post a new series which also includes at least one consumer > for the functionality added by 3/3. > > That will also make it a lot easier to review 3/3 / to consider > other means to reach the same goal. > Rafael, do you concur? Yes, I do. Thanks!