On Sat, Oct 23, 2021 at 01:10:32AM +0800, Chen Yu wrote:
> Introduce a user space tool to make use of the interface exposed by
> Platform Firmware Runtime Update and Telemetry drivers. The users
> can use this tool to do firmware code injection, driver update and
> to retrieve the telemetry data.
...
> #include <linux/ioctl.h>
> +#ifdef __KERNEL__
> #include <linux/uuid.h>
> +#else
> +#include <uuid/uuid.h>
> +#include <linux/types.h>
> +#endif
This is exactly my point why you mustn't use uuid.h in uAPI headers.
...
> + while (1) {
Why not while ((c = getopt_long(...)) != -1) ?
> + int option_index = 0;
> +
> + c = getopt_long(argc, argv, option_string,
> + long_options, &option_index);
> + if (c == -1)
> + break;
> + }
> + }
> +}
...
> + char *uuid = malloc(37);
libuuid doesn't have helpers for this?
Split assignment so if will be closer to its user.
> + if (!uuid) {
> + perror("Can not allocate uuid buffer\n");
> + exit(1);
> + }
--
With Best Regards,
Andy Shevchenko
