> How about putting these definitions near the other related functions > in the same file (like below)? > > ... > extern void shake_page(struct page *p); > extern atomic_long_t num_poisoned_pages __read_mostly; > extern int soft_offline_page(unsigned long pfn, int flags); > > // here? Makes sense to group together with these other RAS bits. I'll move the definitions here. > Otherwise, the patch looks good to me. > > Reviewed-by: Naoya Horiguchi <naoya.horiguchi@xxxxxxx> Thanks for the review! -Tony
