On Mon, Oct 18, 2021 at 12:38:51PM +0200, Hans de Goede wrote: > On 10/18/21 12:31, Andy Shevchenko wrote: > > On Mon, Oct 18, 2021 at 12:16 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: ... > > Btw, IIRC similar code (i.e. BYT vs CHT by CPU > > ID) is being used elsewhere. Perhaps we might have some common > > (library) under arc/x86, PDx86 or so (headers?)? > > We already have helpers for this defined in: > > sound/soc/intel/common/soc-intel-quirks.h > > We could move those to some header under include, maybe: > > include/linux/platform_data/x86/atom.h > > And add #ifdef-ery there so that things will also build on > non x86 ? > > Then we could do a 2 patch series adding the > include/linux/platform_data/x86/atom.h > file + the drivers/mfd/intel_soc_pmic_core.c > change and Lee can merge both through the MFD tree. > > And then we can do further clean-ups of e.g. sound/soc > on top (we can ask Lee to provide an immutable branch). > > How does that sound ? Sounds like a good plan to me! -- With Best Regards, Andy Shevchenko
