On Sun, Oct 17, 2021 at 7:16 PM Tsuchiya Yuto <kitakar@xxxxxxxxx> wrote: > > Hi all, > > Firstly, I'm still not used to Linux patch sending flow. Sorry in advance > if there is some weirdness :-) but I did my best. > > I need to use the function intel_soc_pmic_exec_mipi_pmic_seq_element() > with atomisp Image Signal Processing driver on Microsoft Surface 3 > (Cherry Trail). > > However, it currently fails with the message I added to the commit > message below. I wondered why. The driver intel_pmic_chtcrc does define > the i2c address. > > It later turned out that the intel_pmic_bytcrc driver is used on surface3 > instead, where the i2c address is not defined. So, I added the address > with the patch I'm sending as RFC in this mail. It's working well. > > The question is that, should Surface 3 (Cherry Trail) really use the > intel_pmic_bytcrc driver? I believe Cherry Trail should use the chtcrc driver. -- With Best Regards, Andy Shevchenko
