Hi, On 10/8/21 5:05 AM, André Almeida wrote: > Some buggy firmware and/or brand new batteries can support a charge that's > slightly over the reported design capacity. In such cases, the kernel will > report to userspace that the charging state of the battery is "Unknown", > when in reality the battery charge is "Full", at least from the design > capacity point of view. Make the fallback condition accepts capacities > over the designed capacity so userspace knows that is full. > > Signed-off-by: André Almeida <andrealmeid@xxxxxxxxxxxxx> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> Regards, Hans > --- > drivers/acpi/battery.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c > index dae91f906cea..8afa85d6eb6a 100644 > --- a/drivers/acpi/battery.c > +++ b/drivers/acpi/battery.c > @@ -169,7 +169,7 @@ static int acpi_battery_is_charged(struct acpi_battery *battery) > return 1; > > /* fallback to using design values for broken batteries */ > - if (battery->design_capacity == battery->capacity_now) > + if (battery->design_capacity <= battery->capacity_now) > return 1; > > /* we don't do any sort of metric based on percentages */ >
