On Thu, Oct 7, 2021 at 1:20 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> On Wed, Oct 06, 2021 at 11:50:35PM +1300, Barry Song wrote:
>
> > > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
> > > index 7cb31d959f33..fc0836f460fb 100644
> > > --- a/drivers/base/arch_topology.c
> > > +++ b/drivers/base/arch_topology.c
> > > @@ -622,7 +622,8 @@ void update_siblings_masks(unsigned int cpuid)
> > > if (cpuid_topo->package_id != cpu_topo->package_id)
> > > continue;
> > >
> > > - if (cpuid_topo->cluster_id == cpu_topo->cluster_id) {
> > > + if (cpuid_topo->cluster_id == cpu_topo->cluster_id &&
> > > + cpuid_topo->cluster_id != -1) {
> > > cpumask_set_cpu(cpu, &cpuid_topo->cluster_sibling);
> > > cpumask_set_cpu(cpuid, &cpu_topo->cluster_sibling);
> > > }
> > >
> >
> > Hi Peter,
> > Would you like to change this line in your tree?
>
> Can you please double check:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/log/?h=sched/next
yes. It is correct for patch 1/3, thanks!
BTW, patch2/3 is missing some benchmark data and tested-by/SOB tags, i guess
it is because you are still editing?
barry
