On Tue, Oct 05, 2021 at 10:01:09PM +1300, Barry Song wrote: > On Tue, Oct 5, 2021 at 8:35 PM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote: > > > > On Fri, Sep 24, 2021 at 08:51:03PM +1200, Barry Song wrote: > > > From: Barry Song <song.bao.hua@xxxxxxxxxxxxx> > > > > > > > > > > > Signed-off-by: Yicong Yang <yangyicong@xxxxxxxxxxxxx> > > > Signed-off-by: Barry Song <song.bao.hua@xxxxxxxxxxxxx> > > > > That is not a valid SoB pattern. The first SoB should be the author, the > > last SoB should be the one sending the patch, in this case both are > > Barry. What's Yicong's contribution in all this? > > Yicong made the benchmarks of SPECrate and collected the result data which > is in the commit log. I am not quite sure what is the best tag for > him. Is Tested-by > appropriate in this case? Yeah, that works for me, changed it.