On Fri, 2021-10-01 at 16:57 +0200, Peter Zijlstra wrote: > On Fri, Oct 01, 2021 at 12:39:56PM +0200, Vincent Guittot wrote: > > Hi Barry, > > > > On Fri, 1 Oct 2021 at 12:32, Barry Song <21cnbao@xxxxxxxxx> wrote: > > > Hi Vincent, Dietmar, Peter, Ingo, > > > Do you have any comment on this first series which exposes > > > cluster topology > > > of ARM64 kunpeng 920 & x86 Jacobsville and supports load balance > > > only for > > > the 1st stage? > > > I will be very grateful for your comments so that things can move > > > forward in the > > > right direction. I think Tim also looks forward to bringing up > > > cluster > > > support in > > > Jacobsville. > > > > This patchset makes sense to me and the addition of a new > > scheduling > > level to better reflect the HW topology goes in the right > > direction. > > So I had a look, dreading the selecti-idle-sibling changes, and was > pleasantly surprised they're gone :-) > > As is, this does indeed look like something mergable without too much > hassle. > > The one questino I have is, do we want default y? I also agree that default y is preferable. > > The one nit I have is the Kconfig text, I'm not really sure that's > clarifying what a cluster is. Do you have a preference of a different name other than cluster? Or simply better documentation on what a cluster is for ARM64 and x86 in Kconfig? Thanks. Tim