> Btw, do we have non-DSA networking devices where fw_devlink=on > delaying PHY probes is causing an issue? I don't know if issues have been reported, but the realtek driver has had problems in the past when the generic driver is used. Take a look at r8169_mdio_register(), it does something similar to DSA. What is going to make things interesting is that phy_attach_direct() is called in two different contexts. During the MAC drivers probe, it is O.K. to return EPROBE_DEFER, and let the MAC driver try again later, if we know there is a specific PHY driver for it. But when called during the MAC drivers open() op, -EPROBE_DEFER is not allowed. What to do then is an interesting question. Andrew