Re: [PATCH] ACPI: resources: add legacy irq override exception by DMI info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rafael,

Could you please take a look at this patch and give some comment when you have time, the patch will not introduce the regression like the previous one.

Hi Manuel,

Thanks for your comment. Let's work together to make the keyboard work under Linux kernel.

Regards,

Hui.

On 9/5/21 12:04 AM, Manuel Krause wrote:
Hi Hui Wang and all others,

thank you for notifying me and for giving it a new run for the kernel! ;-)

On 04/09/2021 03:43, Hui Wang wrote:
After the commit 0ec4e55e9f57 ("ACPI: resources: Add checks for ACPI
IRQ override") is reverted, the keyboard of those Medion laptops can't
work again.

To fix the keyboard issue, here adding an override check by DMI info,
this will not affect other machines and this design refers to
the prt_quirks[] in the drivers/acpi/pci_irq.c.

If we meet similar issues on other platforms, we could expand the
table of skip_override_table[] or medion_laptop[].

^
| IMO this is the major positive aspect of this patch, that it enables additions, allowing the kernel to work-around other buggy BIOSs / hardware properly in future.

Maybe https://bugzilla.kernel.org/show_bug.cgi?id=213353 "IRQs for onboard UARTs are not level-triggered with IRQNoFlags even if the parent section has the defaults in PRS" is another candidate to add to the table (but I haven't digged deeply enough into it to be sure).

Many thanks to all helpful people involved,
best regards,

Manuel


BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=213031
BugLink: http://bugs.launchpad.net/bugs/1909814
Reported-by: Manuel Krause <manuelkrause@xxxxxxxxxxxx>
Tested-by: Manuel Krause <manuelkrause@xxxxxxxxxxxx>
Signed-off-by: Hui Wang <hui.wang@xxxxxxxxxxxxx>
---
  drivers/acpi/resource.c | 52 ++++++++++++++++++++++++++++++++++++++++-
  1 file changed, 51 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index ee78a210c606..434c8964f182 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
[...]



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux