On 8/26/2021 9:45 AM, Saravana Kannan wrote:
This is just a quick fix to make this driver work with fw_devlink=on.
The proper fix might need a significant amount of rework of the driver
of the framework to use a component device model.
Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx>
---
drivers/net/dsa/realtek-smi-core.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/dsa/realtek-smi-core.c b/drivers/net/dsa/realtek-smi-core.c
index 8e49d4f85d48..f79c174f4954 100644
--- a/drivers/net/dsa/realtek-smi-core.c
+++ b/drivers/net/dsa/realtek-smi-core.c
@@ -394,6 +394,13 @@ static int realtek_smi_probe(struct platform_device *pdev)
var = of_device_get_match_data(dev);
np = dev->of_node;
+ /* This driver assumes the child PHYs would be probed successfully
+ * before this functions returns. That's not a valid assumption, but
+ * let fw_devlink know so that this driver continues to function with
+ * fw_devlink=on.
+ */
+ np->fwnode.flags |= FWNODE_FLAG_BROKEN_PARENT;
Are we positive this is not an issue that applies generally to all DSA
drivers?
--
Florian
