Hi, On 6/16/21 5:11 PM, Rafael J. Wysocki wrote: > On Wed, Jun 16, 2021 at 4:41 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >> >> Hi, >> >> On 6/16/21 4:22 PM, Rafael J. Wysocki wrote: >>> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> >>> >>> Because acpi_walk_dep_device_list() is only called by the code in the >>> file in which it is defined, make it static, drop the export of it >>> and drop its header from acpi.h. >>> >>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> >> >> Actually, acpi_walk_dep_device_list() was split out as a >> helper function used to implement acpi_dev_clear_dependencies() >> because it will be used outside of drivers/acpi. > > Not exactly. > >> Specifically it will be used in the new intel_skl_int3472 driver: >> https://patchwork.kernel.org/project/platform-driver-x86/patch/20210603224007.120560-6-djrscally@xxxxxxxxx/ > > That driver will use acpi_dev_get_first_consumer_dev() which is based > on acpi_walk_dep_device_list(), but still defined in > drivers/acpi/scan.c. > >> Which I plan to merge into pdx86/for-next today, I've just merged >> your linux-pm/acpi-scan PULL-req which exports acpi_walk_dep_device_list() >> as preparation for this. > > No, the acpi_walk_dep_device_list() is a leftover there AFAICS. You are right, my bad. So with this resolved, this patch is fine too: Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> Regards, Hans
