On Sun, 13 Jan 2008 21:27:40 +0100 supersud501 <supersud501@xxxxxxxx> wrote: > > > Andrew Morton wrote: > > > > So simply reverting this: > > > > commit ac93a3946b676025fa55356180e8321639744b31 > > Author: Stephen Hemminger <shemminger@xxxxxxxxxxxxxxxxxxxx> > > Date: Mon Nov 5 15:52:08 2007 -0800 > > > > sky2: enable PCI config writes > > > > On some boards, PCI configuration space access is turned off by default. > > The 2.6.24 driver doesn't turn it on, and should have. > > > > Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Jeff Garzik <jeff@xxxxxxxxxx> > > > > diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c > > index c27c7d6..4f41a94 100644 > > --- a/drivers/net/sky2.c > > +++ b/drivers/net/sky2.c > > @@ -2791,6 +2791,9 @@ static void sky2_reset(struct sky2_hw *hw) > > sky2_write8(hw, B0_CTST, CS_RST_SET); > > sky2_write8(hw, B0_CTST, CS_RST_CLR); > > > > + /* allow writes to PCI config */ > > + sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_ON); > > + > > /* clear PCI errors, if any */ > > pci_read_config_word(pdev, PCI_STATUS, &status); > > status |= PCI_STATUS_ERROR_BITS; > > > > fixes this regression? > > > > If so, we should revert that change. > > > > > yes, it does. > OK, thanks. I queued up the revert and shall wait to hear from Stephen/David/Jeff on this. > > >> but i noticed another "bug" on 2.6.24-rc7-git with sky2: dmesg shows a > >> lot of lines every 5 seconds: > >> > >> [...] > >> [ 357.400462] sky2 0000:02:00.0: error interrupt status=0xc0000000 > >> [ 362.442039] printk: 41 messages suppressed. > >> [ 362.442043] sky2 0000:02:00.0: error interrupt status=0x80000000 > >> [ 367.439151] printk: 18 messages suppressed. > >> [ 367.439156] sky2 0000:02:00.0: error interrupt status=0x80000000 > >> [ 372.436267] printk: 30 messages suppressed. > >> [ 372.436271] sky2 0000:02:00.0: error interrupt status=0x80000000 > >> [ 377.350236] printk: 19 messages suppressed. > >> [...] > >> > >> since i do not notice any errors (yet) i'll wait till next rc, maybe it > >> will be gone then... > > > > That's not good. is this new behaviour? > > > > > > at least on 2.6.23.12 i doesn't happen, so it's now for me in > 2.6.24-rc7-git4 (but again, not testet in earlier versions of 2.6.24). > > since i do not feel any sideeffects yet after using it for ~6 hours > (besides a really long dmesg-output), it's just a little bit annoying. > > if there's a way to identify the source of the problem besides of > bisecting, just say so and i will take a look into it the next days. if > bisecting is the only (time-consuming) way you have to wait at least > until the next weekend :) 2.6.23 also has this warning in sky2_err_intr() but it doesn't trigger there. Rafael, I think we'd have to class this as a post-2.6.23 regression. - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
