On Tue, Jun 8, 2021 at 2:17 PM Zou Wei <zou_wei@xxxxxxxxxx> wrote: > > convert list_for_each() to list_for_each_entry() where > applicable. > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Signed-off-by: Zou Wei <zou_wei@xxxxxxxxxx> > --- > drivers/pnp/pnpbios/core.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pnp/pnpbios/core.c b/drivers/pnp/pnpbios/core.c > index 9b760e7..669ef47 100644 > --- a/drivers/pnp/pnpbios/core.c > +++ b/drivers/pnp/pnpbios/core.c > @@ -298,14 +298,12 @@ struct pnp_protocol pnpbios_protocol = { > > static int __init insert_device(struct pnp_bios_node *node) > { > - struct list_head *pos; > struct pnp_dev *dev; > char id[8]; > int error; > > /* check if the device is already added */ > - list_for_each(pos, &pnpbios_protocol.devices) { > - dev = list_entry(pos, struct pnp_dev, protocol_list); > + list_for_each_entry(dev, &pnpbios_protocol.devices, protocol_list) { > if (dev->number == node->handle) > return -EEXIST; > } > -- Applied as 5.14 material with rewritten subject and changelog, thanks!