[AMD Public Use]
> -----Original Message-----
> From: Limonciello, Mario <Mario.Limonciello@xxxxxxx>
> Sent: Friday, June 4, 2021 1:58 PM
> To: Raul Rangel <rrangel@xxxxxxxxxxxx>
> Cc: Keith Busch <kbusch@xxxxxxxxxx>; Jens Axboe <axboe@xxxxxx>;
> Christoph Hellwig <hch@xxxxxx>; Sagi Grimberg <sagi@xxxxxxxxxxx>; Rafael
> J . Wysocki <rjw@xxxxxxxxxxxxx>; open list:NVM EXPRESS DRIVER <linux-
> nvme@xxxxxxxxxxxxxxxxxxx>; linux-acpi@xxxxxxxxxxxxxxx;
> david.e.box@xxxxxxxxxxxxxxx; S-k, Shyam-sundar <Shyam-sundar.S-
> k@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Liang,
> Prike <Prike.Liang@xxxxxxx>; Julian Sikorski <belegdol@xxxxxxxxx>
> Subject: Re: [PATCH v5 2/2] acpi: PM: Add quirks for AMD Renoir/Lucienne
> CPUs to force the D3 hint
>
> On 6/4/2021 12:43, Raul Rangel wrote:
> > On Fri, Jun 4, 2021 at 10:54 AM Mario Limonciello
> > <mario.limonciello@xxxxxxx> wrote:
> >
> >> +
> >> +#ifdef CONFIG_X86
> >> +static const struct x86_cpu_id storage_d3_cpu_ids[] = {
> >> + X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 96, NULL), /* Renoir
> */
> >> + X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 104, NULL), /*
> Lucienne */
> >> + {}
> >> +};
> >> +#endif
> >> +
> >
> > Is this the same matching logic that Windows is using?
> >
>
> I don't have access to confirm their logic for it - but they do have an allowlist
> that was used for systems before StorageD3Enable was introduced as well as
> a registry key to override it in Windows.
My understanding from the windows team is that these AMD platforms use the allow list.
Alex
>
> In Linux we can do it a number of ways:
>
> * Detect the CPU in RN/LCN platforms
> - Like I did in this patch
>
> * Detect some other PCI device only present in RN/LCN platforms and set
> this hint
> - Like some earlier versions of this patch series from Prike did
>
> * Introduce a tri-state module parameter like d3=auto,off,on
> - Set up logic behind auto to use acpi_storage_d3 primarily and look at a
> quirk list as a fallback if that was false.
>
> * Add a compile time option to include these quirks in either acpi or nvme.ko
> only if a user selected them.
>
> * Enumerate all the field systems SMBIOS we can find with these CPUs
> - Expect this to be a large quirk list.
>
> I don't have a strong opinion between those two first options, but suspect
> the 3rd through 5th aren't really acceptable or scalable.
>
> I'm open to other suggestions but testers of the patches thus far have made
> it clear that /something/ needs to be done to avoid the problems on RN with
> Linux though.
