Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on next-20210604] [cannot apply to driver-core/driver-core-testing linux/master linus/master v5.13-rc4 v5.13-rc3 v5.13-rc2 v5.13-rc4] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/device-property-Unify-access-to-of_node/20210604-211443 base: ccc252d2e818f6a479441119ad453c3ce7c7c461 config: arm64-randconfig-r016-20210604 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 5c0d1b2f902aa6a9cf47cc7e42c5b83bb2217cf9) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/0day-ci/linux/commit/dfc2a97acf9b5c5ba11d180bf411721f723a9042 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Andy-Shevchenko/device-property-Unify-access-to-of_node/20210604-211443 git checkout dfc2a97acf9b5c5ba11d180bf411721f723a9042 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> drivers/base/property.c:875:48: error: passing 'const struct fwnode_handle *' to parameter of type 'struct fwnode_handle *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] return acpi_dma_supported(to_acpi_device_node(fwnode)); ^~~~~~ include/linux/acpi.h:768:77: note: passing argument to parameter 'fwnode' here static inline struct acpi_device *to_acpi_device_node(struct fwnode_handle *fwnode) ^ drivers/base/property.c:890:48: error: passing 'const struct fwnode_handle *' to parameter of type 'struct fwnode_handle *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] attr = acpi_get_dma_attr(to_acpi_device_node(fwnode)); ^~~~~~ include/linux/acpi.h:768:77: note: passing argument to parameter 'fwnode' here static inline struct acpi_device *to_acpi_device_node(struct fwnode_handle *fwnode) ^ 2 errors generated. vim +875 drivers/base/property.c 863 864 bool device_dma_supported(struct device *dev) 865 { 866 const struct fwnode_handle *fwnode = dev_fwnode(dev); 867 868 /* For DT, this is always supported. 869 * For ACPI, this depends on CCA, which 870 * is determined by the acpi_dma_supported(). 871 */ 872 if (is_of_node(fwnode)) 873 return true; 874 > 875 return acpi_dma_supported(to_acpi_device_node(fwnode)); 876 } 877 EXPORT_SYMBOL_GPL(device_dma_supported); 878 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip