On Thu, May 13, 2021 at 02:45:44PM +0100, Shameer Kolothum wrote: > +/** > + * struct iommu_rmr - Reserved Memory Region details per IOMMU > + * @list: Linked list pointers to hold RMR region info > + * @base_address: base address of Reserved Memory Region > + * @length: length of memory region > + * @sid: associated stream id > + * @flags: flags that apply to the RMR node > + */ > +struct iommu_rmr { > + struct list_head list; > + phys_addr_t base_address; > + u64 length; > + u32 sid; > + u32 flags; > +}; > + > +/* RMR Remap permitted */ > +#define IOMMU_RMR_REMAP_PERMITTED (1 << 0) > + This struct has lots of overlap with 'struct iommu_resv_region'. Any reason the existing struct can't be used here? Regards, Joerg