On Tue, May 18, 2021 at 12:43 AM Daniel Scally <djrscally@xxxxxxxxx> wrote: > > Hi Andy > > On 22/02/2021 14:58, Andy Shevchenko wrote > >> +#include <linux/clk-provider.h> > > > > This is definitely not for *.h. (Not all C files needed this) > > > >> +#include <linux/gpio/machine.h> > > > > Ditto. > > > >> +#include <linux/regulator/driver.h> > >> +#include <linux/regulator/machine.h> > > > > Ditto. > > Bit more delayed than I wanted to be, but I'm just finishing off the v4 > of this. For these includes, I'm using the actual structs from them > rather than pointers, so removing these would mean moving the definition > of struct int3472_discrete_device into one of the source files; you're > happy with that? Either way, please send a v4 and we start over from a fresh view. Thanks! -- With Best Regards, Andy Shevchenko
