RE: [PATCH v3 1/2] ACPI: Add _PLD panel positions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Fabian Wüthrich <me@xxxxxxxx>
> Sent: Sunday, May 9, 2021 9:29 AM
> To: Kaneda, Erik <erik.kaneda@xxxxxxxxx>
> Cc: Linux Media Mailing List <linux-media@xxxxxxxxxxxxxxx>; ACPI Devel
> Maling List <linux-acpi@xxxxxxxxxxxxxxx>; open list:ACPI COMPONENT
> ARCHITECTURE (ACPICA) <devel@xxxxxxxxxx>; Jacopo Mondi
> <jacopo@xxxxxxxxxx>; Zhi, Yong <yong.zhi@xxxxxxxxx>; Sakari Ailus
> <sakari.ailus@xxxxxxxxxxxxxxx>; Cao, Bingbu <bingbu.cao@xxxxxxxxx>; Dan
> Scally <djrscally@xxxxxxxxx>; Qiu, Tian Shu <tian.shu.qiu@xxxxxxxxx>;
> Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>; Moore, Robert
> <robert.moore@xxxxxxxxx>; Wysocki, Rafael J <rafael.j.wysocki@xxxxxxxxx>;
> Len Brown <lenb@xxxxxxxxxx>; Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx>; Rafael J. Wysocki <rafael@xxxxxxxxxx>
> Subject: Re: [PATCH v3 1/2] ACPI: Add _PLD panel positions
> 
> Hi Erik,
> 
Hi Fabian,

> Do I need to add anything to this patch or is it fine like that?

Sorry about the late response. I submitted a pull request on your behalf for ACPICA upstream here: https://github.com/acpica/acpica/pull/689

I'll port it to Linux and circulate on this mailing list after ACPICA does a release (usually about once per month).

Thanks,
Erik
> 
> Thanks,
> Fabian
> 
> On 14.04.21 15:50, Rafael J. Wysocki wrote:
> > On Wed, Apr 14, 2021 at 10:30 AM Fabian Wüthrich <me@xxxxxxxx>
> wrote:
> >>
> >> The ACPI specification v6.3 defines the panel positions in chapter 6.1.8
> >> "_PLD (Physical Location of Device)"
> >>
> >> Signed-off-by: Fabian Wüthrich <me@xxxxxxxx>
> >> Reviewed-by: Daniel Scally <djrscally@xxxxxxxxx>
> >> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> >
> > This is ACPICA material.
> >
> > Erik, can you pick up this one, please?
> >
> >> ---
> >>  include/acpi/acbuffer.h | 9 +++++++++
> >>  1 file changed, 9 insertions(+)
> >>
> >> diff --git a/include/acpi/acbuffer.h b/include/acpi/acbuffer.h
> >> index 18197c16149f..d42e82a82852 100644
> >> --- a/include/acpi/acbuffer.h
> >> +++ b/include/acpi/acbuffer.h
> >> @@ -207,4 +207,13 @@ struct acpi_pld_info {
> >>  #define ACPI_PLD_GET_HORIZ_OFFSET(dword)        ACPI_GET_BITS
> (dword, 16, ACPI_16BIT_MASK)
> >>  #define ACPI_PLD_SET_HORIZ_OFFSET(dword,value)  ACPI_SET_BITS
> (dword, 16, ACPI_16BIT_MASK, value)      /* Offset 128+16=144, Len 16 */
> >>
> >> +/* Panel position defined in _PLD section of ACPI Specification 6.3 */
> >> +#define ACPI_PLD_PANEL_TOP                     0
> >> +#define ACPI_PLD_PANEL_BOTTOM                  1
> >> +#define ACPI_PLD_PANEL_LEFT                    2
> >> +#define ACPI_PLD_PANEL_RIGHT                   3
> >> +#define ACPI_PLD_PANEL_FRONT                   4
> >> +#define ACPI_PLD_PANEL_BACK                    5
> >> +#define ACPI_PLD_PANEL_UNKNOWN                 6
> >> +
> >>  #endif                         /* ACBUFFER_H */
> >> --
> >> 2.31.1
> >>




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux