On Mon, May 10, 2021 at 8:17 AM Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> wrote: > > On Fri, 7 May 2021 15:51:20 -0700 > Dan Williams <dan.j.williams@xxxxxxxxx> wrote: > > > In preparation for sharing cxl.h with other generic CXL consumers, > > move / consolidate some of the memory device specifics to mem.h. > > > > The motivation for moving out of cxl.h is to maintain least privilege > > access to memory-device details since cxl.h is used in multiple files. > > The motivation for moving definitions into a new mem.h header is for > > code readability and organization. I.e. minimize implementation details > > when reading data structures and other definitions. > > > > Reviewed-by: Ben Widawsky <ben.widawsky@xxxxxxxxx> > > Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx> > I'll do these one by one as not sure if you use automated scripts to pick up > (which get confused by any time people do "for patches 1-4 + 7") > Basically I'm fine with all but patch 5... Sounds good. I do use b4 which has the "--apply-cover-trailers" option. So in the future if you do want to apply reviewed-by to the whole series it's sufficient to just reply to the cover letter. > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> Thanks, Jonathan.