On Tue, May 11, 2021 at 8:57 PM Limonciello, Mario <Mario.Limonciello@xxxxxxx> wrote: > > > > > > > Actually I think the value set in the OEM BIOS for state2 from LPI looks bogus > > > too. > > > It should have been 36us. > > > > > > @Liang, Prike and @Deucher, Alexander you have some more history on this > > > than I do. > > > > I think they were just bogus, at least in the initial cases where we saw this. > > > > In processor_idle.c target residency is calculated by exit latency multiplied by > a latency factor parameter (2 by default). So when these systems have the buggy > _CST C2 value of 400, that's where the 800 comes from for residency, not _LPI. Yes, that's right, sorry for the confusion. My point was mostly whether or not it would be sufficient to swap the values for the last two states or if some new values needed to be used and the answer appears to be the latter. So I don't see any way to address this that would be cleaner than the quirk mechanism as proposed.