On 4/30/2021 9:40 AM, Greg Kroah-Hartman wrote:
On Thu, Apr 29, 2021 at 01:24:06PM -0400, George Kennedy wrote:
On 4/28/2021 8:52 AM, George Kennedy wrote:
On 4/28/2021 12:57 AM, Greg Kroah-Hartman wrote:
On Tue, Apr 27, 2021 at 06:18:05PM -0400, George Kennedy wrote:
CC+ stable@xxxxxxxxxxxxxxx
On 4/27/2021 6:17 PM, George Kennedy wrote:
Hello Greg,
We need the following 2 upstream commits applied to 5.4.y to
fix an iBFT
boot failure:
2021-03-29 rafael.j.wysocki@xxxxxxxxx - 1a1c130a 2021-03-23 Rafael J.
Wysocki ACPI: tables: x86: Reserve memory occupied by ACPI tables
2021-04-13 rafael.j.wysocki@xxxxxxxxx - 6998a88 2021-04-13 Rafael J.
Wysocki ACPI: x86: Call acpi_boot_table_init() after
acpi_table_upgrade()
Currently, only the first commit (1a1c130a) is destined for
5.10 & 5.11.
The 2nd commit (6998a88) is needed as well and both commits are needed
in 5.4.y.
Is this a regression (i.e. did this hardware work on older kernels?),
and if so, what commit caused the problem?
These commits are already in 5.10.y, what changed in older kernels to
require this to be backported?
Hello Greg,
Can the same 2 patches also be applied to 4.14.y, which one of distros is
based on?
4.14.y crashes during ibft boot with KASAN enabled without the 2 patches.
What about 4.19.y? You do not want to skip anything in the middle,
right?
And I need an ack from the authors and maintainers of these changes
before I can take them into the stable trees. Any reason you didn't cc:
them all?
CC+ maintainers
Rafael and Mike,
We need Rafael's 2 upstream ACPI commits (1a1c130a & 6998a88) backported
to more of the stable branches - at least in 5.4.y, 4.14.y, and 4.19.y.
Can you (along with the other maintainers) ACK the request?
Without the 2 ACPI commits, the failure occurs in latest 4.19.y and
other stable branches. Rafael's 2 ACPI commits fix the crash.
[ 17.239703] iscsi: registered transport (iser)
[ 17.241038] OPA Virtual Network Driver - v1.0
[ 17.242833] iBFT detected.
[ 17.243593]
==================================================================
[ 17.243615] BUG: KASAN: use-after-free in ibft_init+0x134/0xab7
[ 17.243615] Read of size 4 at addr ffff8880be451004 by task swapper/0/1
[ 17.243615]
[ 17.243615] CPU: 2 PID: 1 Comm: swapper/0 Not tainted
4.19.190-rc1-1bd8f1c #1
[ 17.243615] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996),
BIOS 0.0.0 02/06/2015
[ 17.243615] Call Trace:
[ 17.243615] dump_stack+0xb3/0xf0
[ 17.243615] ? ibft_init+0x134/0xab7
[ 17.243615] print_address_description+0x71/0x239
[ 17.243615] ? ibft_init+0x134/0xab7
[ 17.243615] kasan_report.cold.6+0x242/0x2fe
[ 17.243615] __asan_report_load_n_noabort+0x14/0x20
[ 17.243615] ibft_init+0x134/0xab7
[ 17.243615] ? dcdrbu_init+0x1e6/0x225
[ 17.243615] ? ibft_check_initiator_for+0x14a/0x14a
[ 17.243615] ? ibft_check_initiator_for+0x14a/0x14a
[ 17.243615] do_one_initcall+0xb6/0x3a0
[ 17.243615] ? perf_trace_initcall_level+0x430/0x430
[ 17.243615] ? kasan_unpoison_shadow+0x35/0x50
[ 17.243615] kernel_init_freeable+0x54d/0x64d
[ 17.243615] ? start_kernel+0x7e9/0x7e9
[ 17.243615] ? __switch_to_asm+0x41/0x70
[ 17.243615] ? kasan_check_read+0x11/0x20
[ 17.243615] ? rest_init+0xdc/0xdc
[ 17.243615] kernel_init+0x16/0x180
[ 17.243615] ? rest_init+0xdc/0xdc
[ 17.243615] ret_from_fork+0x35/0x40
[ 17.243615]
[ 17.243615] The buggy address belongs to the page:
[ 17.243615] page:ffffea0002f91440 count:0 mapcount:0
mapping:0000000000000000 index:0x1
[ 17.243615] flags: 0xfffffc0000000()
[ 17.243615] raw: 000fffffc0000000 ffffea0002df9708 ffffea0002f91408
0000000000000000
[ 17.243615] raw: 0000000000000001 0000000000000000 00000000ffffffff
0000000000000000
[ 17.243615] page dumped because: kasan: bad access detected
[ 17.243615]
[ 17.243615] Memory state around the buggy address:
[ 17.243615] ffff8880be450f00: ff ff ff ff ff ff ff ff ff ff ff ff ff
ff ff ff
[ 17.243615] ffff8880be450f80: ff ff ff ff ff ff ff ff ff ff ff ff ff
ff ff ff
[ 17.243615] >ffff8880be451000: ff ff ff ff ff ff ff ff ff ff ff ff ff
ff ff ff
[ 17.243615] ^
[ 17.243615] ffff8880be451080: ff ff ff ff ff ff ff ff ff ff ff ff ff
ff ff ff
[ 17.243615] ffff8880be451100: ff ff ff ff ff ff ff ff ff ff ff ff ff
ff ff ff
[ 17.243615]
==================================================================
Thank you,
George
thanks,
greg k-h
