> -----Original Message----- > From: Andrew Jones [mailto:drjones@xxxxxxxxxx] > Sent: Wednesday, April 28, 2021 9:48 PM > To: Song Bao Hua (Barry Song) <song.bao.hua@xxxxxxxxxxxxx> > Cc: aubrey.li@xxxxxxxxxxxxxxx; bp@xxxxxxxxx; bsegall@xxxxxxxxxx; > catalin.marinas@xxxxxxx; dietmar.eggemann@xxxxxxx; > gregkh@xxxxxxxxxxxxxxxxxxx; guodong.xu@xxxxxxxxxx; hpa@xxxxxxxxx; Jonathan > Cameron <jonathan.cameron@xxxxxxxxxx>; juri.lelli@xxxxxxxxxx; > lenb@xxxxxxxxxx; Liguozhu (Kenneth) <liguozhu@xxxxxxxxxxxxx>; > linux-acpi@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; linuxarm@xxxxxxxxxxxxx; mark.rutland@xxxxxxx; > mgorman@xxxxxxx; mingo@xxxxxxxxxx; msys.mizuma@xxxxxxxxx; > peterz@xxxxxxxxxxxxx; Zengtao (B) <prime.zeng@xxxxxxxxxxxxx>; > rjw@xxxxxxxxxxxxx; rostedt@xxxxxxxxxxx; sudeep.holla@xxxxxxx; > tglx@xxxxxxxxxxxxx; tim.c.chen@xxxxxxxxxxxxxxx; valentin.schneider@xxxxxxx; > vincent.guittot@xxxxxxxxxx; will@xxxxxxxxxx; x86@xxxxxxxxxx; xuwei (O) > <xuwei5@xxxxxxxxxx>; yangyicong <yangyicong@xxxxxxxxxx> > Subject: Re: [RFC PATCH v6 1/4] topology: Represent clusters of CPUs within > a die > > On 20/04/2021 12:18, Barry Song wrote: > ... > > Currently the ID provided is the offset of the Processor > > Hierarchy Nodes Structure within PPTT. Whilst this is unique > > it is not terribly elegant so alternative suggestions welcome. > > > > The ACPI table offsets are consistent with how other topology IDs are > generated. I once tried to make them a little more human friendly with > [1], but it was nacked. > > [1] https://lore.kernel.org/lkml/20180629132934.GA16282@e107155-lin/t/ > Ideally, we are going to check if cluster node has a valid UID, if yes, read this ID; otherwise, fall back to use offset. Will move to that way in next version. > Thanks, > drew Thanks Barry
