On Mon, Apr 12, 2021 at 8:01 PM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
>
> On Mon, Apr 12, 2021 at 7:38 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> >
> > Hi Rafael,
> >
> > Sorry about the timing of reporting this regression.
>
> Oh well.
>
> > I just noticed that overriding the DSDT (*) from the initrd will not work in 5.12,
> > this is caused by:
> >
> > commit 1a1c130ab757 ("ACPI: tables: x86: Reserve memory occupied by ACPI tables")
> >
> > This makes the initial acpi_locate_initial_tables() call happen earlier
> > then before, but the acpi_table_upgrade) call in arch/x86/kernel/setup.c is
> > not moved up, so the tables in the initrd are now only parsed and saved
> > after the initial ACPI table scanning has already been done.
> >
> > I guess fixing this might be as easy as moving the acpi_table_upgrade) call
> > higher in arch/x86/kernel/setup.c but I'm not sure if that is save to do.
>
> Why do you think it may not be safe?
OK, so it won't work in some cases, because acpi_table_upgrade() needs
to be called after reserve_initrd(), so I guess the commit above will
need to be reverted.
