On Monday 17 December 2007 09:40:19 Alexey Starikovskiy wrote:
> > +/*
> > + * WMI can have EmbeddedControl access regions. In which case, we just
> > want to + * hand these off to the EC driver.
> > + */
> > +static acpi_status
> > +acpi_wmi_ec_space_handler(u32 function, acpi_physical_address address,
> > + u32 bits, acpi_integer *value,
> > + void *handler_context, void *region_context)
> > +{
> > + int result = 0, i = 0;
> > + u8 temp = 0;
> > +
> > + if ((address > 0xFF) || !value)
> > + return AE_BAD_PARAMETER;
> > +
> > + if (function != ACPI_READ && function != ACPI_WRITE)
> > + return AE_BAD_PARAMETER;
> > +
>
> You probably don't need to handle more than 1 byte here -- even in EC it
> is legacy...
So would putting back in something like:
if (bits != 8)
return AE_BAD_PARAMETER;
Be the right solution? (acpi_strict test is removed compared to EC, since it's
no longer exported, and WMI can be built as a module)
-Carlos
--
E-Mail: carlos@xxxxxxxxxxxxxxxxxxx
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
