On Wednesday 14 November 2007 10:06, Dmitry Torokhov wrote: > On 11/14/07, Henrique de Moraes Holschuh <hmh@xxxxxxxxxx> wrote: > > On Wed, 14 Nov 2007, Zhang Rui wrote: > > > On Tue, 2007-11-06 at 00:43 +0800, Dmitry Torokhov wrote: > > > > ACPI: video - properly handle errors when registering proc elements > > > > > > > > Have acpi_video_device_add_fs() and acpi_video_bus_add_fs() > > > > properly unwind proc creation after error. > > > Hi, Dmitry, > > > > > > The patch is good. > > > But I'm afraid we don't need this patch while we are trying to remove > > > the proc I/F for all ACPI device drivers. > > > > IMHO, until procfs is gone for good, it is best to make sure it works > > perfectly. > > > > That is my position as well. The removal is scheduled for July 2008 > which is 9 months out. Agreed. While we don't want to add (and support) any new /proc features, unwinding from errors properly with the existing features seems like a good idea. thanks, -Len - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
