On Tue, 2007-11-06 at 00:43 +0800, Dmitry Torokhov wrote: > ACPI: video - more cleanups > > Remove unneeded checks and initializations, implement proper > unwinding after errors in initialization code, get rid of > unneeded casts, adjust formatting. A big patch with a large number of minor cleanups/fixes. Thanks for your work, Dmitry. I'm okay with this one except the comment below. > Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx> > @@ -1772,12 +1783,11 @@ static int acpi_video_bus_stop_devices(s > static void acpi_video_bus_notify(acpi_handle handle, u32 event, void > *data) > { > struct acpi_video_bus *video = data; > - struct acpi_device *device = NULL; > + struct acpi_device *device; > struct input_dev *input; > int keycode; > > - > - printk("video bus notify\n"); > + printk(KERN_DEBUG "video bus notify\n"); This debug message should be removed. Thanks, Rui - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html