Re: [PATCH] ACPI: Cleanup <linux/acpi.h>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 7 Nov 2007 14:20:56 +0100
Jean Delvare <jdelvare@xxxxxxx> wrote:

> Two cleanups to <linux/acpi.h>:
> * Stop defining acpi_mp_config, it isn't used anywhere.
> * Discard nested "#ifdef CONFIG_ACPI", they are useless and
>   error-prone.

It's not a good time to be doing not-strictly-needed cleanup patches
in there.

> Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
> ---
> Len, Andrew, this cleanup should go before the patches sent by
> Thomas Renninger. I'll send updated patches in a moment so that
> we no longer break the build for CONFIG_ACPI=n.

I'm quite confused.  I have the following acpi-affecting patches for this
work:

small-acpica-extension-to-be-able-to-store-the-name-of.patch
small-acpica-extension-to-be-able-to-store-the-name-of-fix.patch
export-acpi_check_resource_conflict.patch
export-acpi_check_resource_conflict-fix.patch
mm-only-enforce-acpi-resource-conflict-checks.patch

But now I see two new patches called

Subject: [PATCH] Provide acpi_check_{mem_}region (update)
Subject: [PATCH] ACPI: Export acpi_check_resource_conflict() (update #2)

<checks>

OK, the first is a renamed version of
small-acpica-extension-to-be-able-to-store-the-name-of.patch, perhaps of
small-acpica-extension-to-be-able-to-store-the-name-of.patch+small-acpica-extension-to-be-able-to-store-the-name-of-fix.patch.
I guess I need to dive into the diffs to find out whether the fix got lost
or not.

Please don't rename patches.


<looks more>

OK, afacit all we've done here is added this cleanup patch and then churned
all the other patches on top of it.  After fixing rejects in the
now-combined
small-acpica-extension-to-be-able-to-store-the-name-of.patch+small-acpica-extension-to-be-able-to-store-the-name-of-fix.patch
I didn't need "Provide acpi_check_{mem_}region (update)" and "ACPI: Export
acpi_check_resource_conflict() (update #2)" is just a little cleanup.

-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux