On Monday, 22 October 2007 12:18, Alexey Starikovskiy wrote: > With the auto selection of operation mode, absence of GPEs does not > really degrade performance, so let PM code to handle > enabling/disabling GPEs. > This is a revert of 5d57a6a55ec0bdcb952dbcd3f8ffcde8a3ee9413, > which was meant to be temporary. > > Reference: http://bugzilla.kernel.org/show_bug.cgi?id=7977 > > Signed-off-by: Alexey Starikovskiy <astarikovskiy@xxxxxxx> > --- Acked-by: Rafael J. Wysocki <rjw@xxxxxxx> [I'm not sure about the resolution of the above bug, though.] > drivers/acpi/ec.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c > index 50d55fe..41a21fc 100644 > --- a/drivers/acpi/ec.c > +++ b/drivers/acpi/ec.c > @@ -258,9 +258,6 @@ static int acpi_ec_transaction(struct acpi_ec *ec, u8 command, > } > } > > - /* Make sure GPE is enabled before doing transaction */ > - acpi_enable_gpe(NULL, ec->gpe, ACPI_NOT_ISR); > - > status = acpi_ec_wait(ec, ACPI_EC_EVENT_IBF_0, 0); > if (status) { > printk(KERN_ERR PREFIX > @@ -638,12 +635,10 @@ static struct acpi_ec *make_acpi_ec(void) > struct acpi_ec *ec = kzalloc(sizeof(struct acpi_ec), GFP_KERNEL); > if (!ec) > return NULL; > - > ec->flags = 1 << EC_FLAGS_QUERY_PENDING; > mutex_init(&ec->lock); > init_waitqueue_head(&ec->wait); > INIT_LIST_HEAD(&ec->list); > - > return ec; > } > > > > -- "Premature optimization is the root of all evil." - Donald Knuth - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html