On 14/05/2007, Stefan Seyfried <seife@xxxxxxx> wrote: > On Fri, May 11, 2007 at 03:51:38PM -0700, Linus Torvalds wrote: > > > > > > On Fri, 11 May 2007, Rafael J. Wysocki wrote: > > > > > > Just to clarify, the change in question isn't new. It was introduced by the > > > commit 9185cfa92507d07ac787bc73d06c42222eec7239 before 2.6.20, at Seife's > > > request and with Pavel's acceptance. > > > > Ok, if it's that old, we migt as leave it in. Clearly there weren't many > > regressions, and this isn't a case of other monsters lurking behind a lack > > of testers. > > I pushed for this since on ACPI machines, "platform" is the right thing to do, > and i still think it will only break on machines that have a broken ACPI BIOS. > (Are there machines with broken ACPI BIOS around? ;-) > > Your additional "fall back to shutdown if !(ops)"-fix looks very sane, > however, and is definitely a good idea. The key point is "fall back to shutdown _only_ if !ops, otherwise don't touch hibernation_mode". And that solves my problem. -- Qi Yong - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
