On Tue, 09 Oct 2007, Matthew Garrett wrote: > On Tue, Oct 09, 2007 at 11:46:48AM +0200, Thomas Renninger wrote: > > > More important: CONFIG_THINKPAD_ACPI_BACKLIGHT_DESIRED variable is error > > prone and should not get introduced, right? Error prone how? Please expand, because right now I am not inclined to remove that variable. It is optional, and disabled by default. Distros are not going to enable it unless they have a damn good reason to, and it is not even something that one can enable at runtime. Should I make the help text stronger against enabling the option? Is it not clear enough? If you look at the patch, you will notice that the backlight changes are small, and the biggest part of them affects __init code, which I make exactly *zero* effort to optimize for size: it is basically "free" for the scenarios I have to bother with (thinkpads). > backlight functionality if it can be controlled through the standard > mechanism instead. Well, it is a simple matter of removing the Kconfig option and making that code non-optional. But I am not adding a remove-video-support Kconfig option at this time. It will wait until I break the driver down into multiple modules. I still want a stronger reason to remove the backlight functionality possibility on newer thinkpads, though. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
