Re: [patch 8/8] acpi: fix BDC handling in drivers/acpi/sleep/proc.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



By the way, another longstanding bug in this /proc/acpi/... code is:

> @@ -336,11 +328,11 @@ acpi_system_write_alarm(struct file *fil
>  	 * to the RTC area of memory.
>  	 */
>  	if (acpi_gbl_FADT.day_alarm)
> -		CMOS_WRITE(day, acpi_gbl_FADT.day_alarm);
> +		cmos_bcd_write(day, acpi_gbl_FADT.day_alarm, rtc_control);
>  	if (acpi_gbl_FADT.month_alarm)
> -		CMOS_WRITE(mo, acpi_gbl_FADT.month_alarm);
> +		cmos_bcd_write(mo, acpi_gbl_FADT.month_alarm, rtc_control);
>  	if (acpi_gbl_FADT.century)
> -		CMOS_WRITE(yr / 100, acpi_gbl_FADT.century);
> +		cmos_bcd_write(yr / 100, acpi_gbl_FADT.century, rtc_control);

The "century" field is unrelated to the alarm.  It's purely
a way to distinguish 19xx vs 20xx (and 21xx, etc).

>  	/* enable the rtc alarm interrupt */
>  	rtc_control |= RTC_AIE;
>  	CMOS_WRITE(rtc_control, RTC_CONTROL);
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux