Frans Pop wrote:
> On Thursday 20 September 2007, you wrote:
>> Please try this patch.
>
> Works. All states are now listed again.
> I've not tested suspend to disk, but suspend to ram and power off work fine.
>
>> +printk(KERN_INFO PREFIX "(supports");
>> #ifdef CONFIG_SUSPEND
>> - printk(KERN_INFO PREFIX "(supports");
>> for (i = ACPI_STATE_S0; i < ACPI_STATE_S4; i++) {
>
> Isn't there a risk now that we now end up printing
> ACPI: (supports)
> if CONFIG_SUSPEND is not enabled and >S4 is not supported?
>
> Or, more probably, it would print
> ACPI: (supports S5)
Don't know what does it mean to support S0 exactly... :)
> as it is unlikely that "off" is not supported :-)
>
> Maybe S0 should be taken outside the #ifdef and the loop as that state is
> also basically always there?
Don't think it is worth the trouble. We already have this loop almost completely unrolled,
let's not make it complete mess...
Regards,
Alex.
>
> Thanks,
> FJP
>
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
