Re: [PATCH] sony-laptop/thinkpad-acpi: fix build error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 18, 2007 at 12:49:14PM -0400, Len Brown wrote:
> 
> I'd prefer to use "depends on" here, as "select" is sort
> of a last resort, given its inherent disfunctionalty
> (is that a word?:-)

Yes, select is evil as it does not take care of "select" and
"depends on" statements of the selected config option.

> yes, I wish "select" worked the way programmers want it to,
> but it doesn't.  Indeed, the only reason using it here is technically
> correct is that both these invocations depends on X86 and that
> avoids the conflict with !s390 INPUT.

Hmm, wasn't especially aware of that.

> Also, the reality is that all configs that want these drivers
> will have INPUT set already -- something that probably could
> not be said of BACKLIGHT_CLASS_DEVICE etc. -- so this patch
> is really just to please randconfig.

Right you are. Randconfig found that one.

> Unless you object, I'll just change this to "depends on" when i apply it.

No, I don't object.


Regards,

Andreas

-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux