Re: [PATCH V3 1/3] ACPI video hotkey: add new input key code for ACPI video hotkey events

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 23 August 2007 17:22, Henrique de Moraes Holschuh wrote:
> On Thu, 23 Aug 2007, Dmitry Torokhov wrote:
> > On 8/23/07, Len Brown <lenb@xxxxxxxxxx> wrote:
> > > Thanks for the refreshed patch series, Rui.
> > > I've added it to acpi-test.
> > >
> > > Still waiting on an ACK from Dmitry on the input.h definitions.
> > 
> > Sorry, I am still trying to recover from a hard drive failure...
> > 
> > The keycodes conflict with a pending patch adding KEY_BRL_DOT9 and
> > KEY_BRL_DOT10 and so have to be moved somewhere else.
> 
> Also, this one:
> +#define KEY_DISPLAY_CYCLE      0x1f9                                                                                                      
> 
> Should probably be
> #define KEY_DISPLAY_CYCLE	KEY_SWITCHVIDEOMODE
> 
> According to what was explained to us (thinkpad-acpi and the other laptop
> hotkey drivers).

I agree.  I noticed this also
and I'll send a refreshed patch shortly.

thanks,
-Len
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux