On Fri, 2007-08-17 at 13:11 +0800, Alexey Starikovskiy wrote: > Zhang Rui wrote: > > On Thu, 2007-08-16 at 18:03 +0400, Alexey Starikovskiy wrote: > >> From: Alexey Starikovskiy <astarikovskiy@xxxxxxx> > >> > >> acpi_bus_generate_event() takes two strings out of passed device > object. > >> SBS needs to supply these strings directly. > >> > > This doesn't make sense. > > acpi_dev->dev.bus_id is the name we are using for ACPI device in > sysfs. > > That's why acpi_dev->dev.bus_id is exported via netlink message > rather > > than the acpi_dev.pnp.bus_id. > > BTW: what's wrong with the old acpi_sbs_generate_event thing? > There are up to 5 devices in SBS which could send a message. those devices all have a device node in sysfs if they support the power_supply class, right? > From ACPI point of view this is one device. That doesn't matter. Both the device_class and bus_id are for user space to identify what the event is. So why not export "power_supply" as the device_class, and the sysfs nodes name for these devices as the bus_id? So that it's easy for user space to know this is a "power supply" event and can configure the sys I/F in /sys/class/power_supply/bus_id/... Thanks, Rui > Copying strings before and after sending event seems to be mess to me. - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
