On Wed, 2007-08-08 at 16:43 +0000, Dave Young wrote: > Hi, > > [This fix is not very good for the global variable, any comments are > welcome.] > > The thinkpad_acpi module_init fail out entrace is not very properly. if > failing before register driver or before create sysfs file, the > module_exit will try to remove nonexist sysfs files, the kernel will > oops. This one is already fixed in Len's git tree in the test branch and will get merged to Linus soon (commit id: ac36393de6034be7266264a435360e7628849005). The (similar) patch got posted on linux-acpi with subject: [PATCH 05/12] ACPI: thinkpad-acpi: fix the module init failure path (Fri, 3 Aug 2007 18:33:38) Thomas - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html