Re: [PATCH][ACPI] Let's not gamble that a possible double free will never happen in asus_hotk_get_info()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/08/07, Len Brown <lenb@xxxxxxxxxx> wrote:
> On Saturday 28 July 2007 18:45, Jesper Juhl wrote:
> > Signed-off-by: Jesper Juhl <jesper.juhl@xxxxxxxxx>
> > ---
> >
> > drivers/acpi/asus_acpi.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/acpi/asus_acpi.c b/drivers/acpi/asus_acpi.c
> > index 9c4bd22..86fd142 100644
> > --- a/drivers/acpi/asus_acpi.c
> > +++ b/drivers/acpi/asus_acpi.c
> > @@ -1192,6 +1192,7 @@ static int asus_hotk_get_info(void)
> > break;
> > default:
> > kfree(model);
> > +model = NULL;
> > break;
> > }
> > }
>
> applied.
>
> coverity didn't find the bug below this code however.
> we can also leak model in the path that returns  OK.
>
Whoops, I should have spotted that.  I assume you've now fixed that locally?

-- 
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux