On Mon, 30 Jul 2007, Dmitry Torokhov wrote: > I have some concerns over this patch. Some of the events reported are > not the regular key presses that something needs to process and > perform an action. Consider ACPI_VIDEO_NOTIFY_SWITCH is "Used to > notify OSPM whenever the state of one of the output devices attached > to the VGA controller has been switched or toggled." As far as I > understand the event (whatever it was) was already processed by > firmware and we getting a notification event of system change. So I am > not sure that this event should be sent as a key event. This is the whole "passive and active input events" crap I went over with thinkpad-acpi not too long ago. Can we please get a formal documentation in input of how it should be done, and declare anything that doesn't follow it "buggy"? You know my position on it: a new event type, or not producing such events at all. But I will follow whatever rule the input layer sets. > The brightness events on the other hand seem to be perfectly suited > for an input device (unless are are also already processed by the > firmware and action has already been taken). Agreed. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
