On Tue, 2007-07-31 at 11:08 +0200, Rafael J. Wysocki wrote: > On Monday, 30 July 2007 17:33, Richard Hughes wrote: > > On Mon, 2007-07-30 at 17:21 +0200, Thomas Renninger wrote: > > > On Tue, 2007-07-17 at 12:15 +0100, Richard Hughes wrote: > > > > On resume we need to refresh the lid status as we will not get an event if > > > > the lid opening was what triggered the suspend. > > > > This manifests itself in users never getting a "lid open" event when a > > > > suspend happens because of lid close on hardware that supports wake on > > > > lid open. This makes userspace gets very confused indeed. > > > > Patch inline (and also attached) forces a check of the lid status in the > > > > resume handler. > > > Is this a general problem on all machines? > > > > I've only seen myself it on new ThinkPads such as the T61 and X60, > > although I've been getting a few bug reports about other IBM laptops. > > > > > Or does this only happen if "shutdown" suspend mode is used? > > > > No, I don't believe so. > > > > > I could imagine a lot machines let it up to OS to check for LID state > > > change, then this one should be added. > > > > I guess it's up to the BIOS, and I don't think this refresh hurts any > > machines that implement a notify on resume, and fixes a fair few > > machines that don't. > > AFAICS, the notify doesn't seem to work very well on some machines. Agree. > Are there any downsides of the $subject patch? Not that I've found. I've been testing it on ~6 IBM and non-IBM machines with no bad effects so far. Richard. - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
