Len Brown wrote: > On Thursday 26 July 2007 06:07, Gabriel C wrote: > >>> If you feel that your system has been degraded >>> because it now includes what used to be excluded under >>> CONFIG_ACPI_SLEEP=n, please let me know how. >> Even if I want to SUSPEND* to <something> I can't on my Dell Precision 530 boxes , >> SCSI is broken with suspend therefore all these boxes have the whole SUSPEND* off, >> all I need is ACPI. > > Linux is already way behind the competition on both STR and STD. > Disabling it because it doesn't work will makes this situation > worse, not better. Heh what else can I do ? The _bug_(s) are reporter for ages. See this one as example ( this kills all my Dells ) and there are a lot more reported. http://bugzilla.kernel.org/show_bug.cgi?id=3062 ... Description From Nathan Bryant 2004-07-13 18:14 ... Notice '2004' and still no one really cares .. So all I can do for now is to disable it. > >> So why you think I want to have this all enabled by default now ? >> Just to bloat the kernel with something doesn't even work for me ? > > Can you be specific about how much additional "bloat" your system > must endure with CONFIG_ACPI_SLEEP=y At least I was not forced to use HOTPLUG_CPU .. Really I just enable what I need / works on my box(es). > >>>> config ACPI_SLEEP >>>> select HOTPLUG_CPU if X86 && SMP >>>> select SUSPEND_SMP if X86 && SMP >>>> >>>> instead of makeing it dependant on ACPI. >>> If more config options where better, then this >>> would indeed be an improvement over 2.6.22. >>> But more config options isn't better -- except for "some people":-) >> But in this case some config / new config is better. >> >> I do not need ACPI to SUSPEND but to make the box work properly. > > You also don't need a lot of other code in your kernel. > > At some point the complexity of supporting more configuration options > out-weights the benefits of having them. I have a pretty good idea > of the cost of maintaining the code. So my question to you is > is what, exactly, is the benefit of having 2.6.22 CONFIG_ACPI_SLEEP=y > that is now lost in 2.6.23-git? > >> Ohh and isn't better to make 'ACPI_PROCESSOR select SUSPEND_SMP and HOTPLUG_CPU if X86 && SMP' ? >> >> ... >> >> config ACPI_PROCESSOR >> tristate "Processor" >> default y >> help >> This driver installs ACPI as the idle handler for Linux, and uses >> ACPI C2 and C3 processor states to save power, on systems that >> support it. It is required by several flavors of cpufreq >> Performance-state drivers. >> >> ... >> >> Is more logical for me to do it here but I may be wrong. > > ACPI_PROCESSOR supports C-states and P-states and is not directly > related to support for system sleep states. If your system is recent, > then it is likely that you want to enable this (and cpufreq) to save power -- > even if you are not interested in system-wide sleep states. Oh ok. Well then add a dummy config onpion, ACPI_DESKTOP_SUSPEND or something , move the 2 selects to there , make it visible in the menu and make it even default y but that way one can disable it. You have a config option more even you hate that =) but no #ifdef's in code. > > -Len > Gabriel - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
