On Mon, Jul 16, 2007 at 09:22:28AM -0400, Dmitry Torokhov wrote:
> Hi Mattia,
>
> On 7/15/07, Mattia Dongili <malattia@xxxxxxxx> wrote:
>> +static int sony_laptop_input_keycode_map[] = {
>> + KEY_RESERVED, /* no event... */
>> + KEY_RESERVED, /* SONYPI_EVENT_JOGDIAL_DOWN */
>> + KEY_RESERVED, /* SONYPI_EVENT_JOGDIAL_UP */
>> + KEY_RESERVED, /* SONYPI_EVENT_JOGDIAL_DOWN_PRESSED */
>> + KEY_RESERVED, /* SONYPI_EVENT_JOGDIAL_UP_PRESSED */
>> + KEY_RESERVED, /* SONYPI_EVENT_JOGDIAL_PRESSED */
>> + KEY_RESERVED, /* SONYPI_EVENT_JOGDIAL_RELEASED */
>
> Jogdial events are never passed through key_dev, do they? If so then
> we should not allow remapping them as it is pointless. EVCSKEYCODE
> shoudl return -EINVAL wehn trying to remap them.
yes, JOG events are going to the other input_dev.
...
>> + KEY_RESERVED, /* SONYPI_EVENT_LID_CLOSED */
>> + KEY_RESERVED, /* SONYPI_EVENT_LID_OPENED */
>
> EV_SW/SW_LID unless LID events are delivered through ACPI (in which
> case we should hide these events completely).
every event except jogdial's is also being delivered through ACPI. Will
hide these from input then.
...
>> + KEY_RESERVED, /* SONYPI_EVENT_ANYBUTTON_RELEASED */
>> + KEY_RESERVED, /* SONYPI_EVENT_BATTERY_INSERT */
>> + KEY_RESERVED, /* SONYPI_EVENT_BATTERY_REMOVE */
ACPI only stuff as well?
>> + KEY_RESERVED, /* SONYPI_EVENT_FNKEY_RELEASED */
>
> Do we really want let userspace remap this event?
hehehe, no, I don't think so.
Thanks for the comments
--
mattia
:wq!
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
