Re: pci-ids: add Lenovo PCI vendor ID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 15 Jul 2007, Jeff Garzik wrote:
> Henrique de Moraes Holschuh wrote:
>> thinkpad-acpi wants to differentiate IBM from Lenovo ThinkPads, and the 
>> PCI
>> IDs are the best way to go about it for quirk tables and so on.  Add the
>> missing Lenovo PCI ID to pci_ids.h.
>> Signed-off-by: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>
>> Cc: Jeff Garzik <jeff@xxxxxxxxxx>
>> ---
>>  include/linux/pci_ids.h |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>> index 5b1c999..b5f54ca 100644
>> --- a/include/linux/pci_ids.h
>> +++ b/include/linux/pci_ids.h
>> @@ -2067,6 +2067,8 @@
>>  #define PCI_DEVICE_ID_ALTIMA_AC9100	0x03ea
>>  #define PCI_DEVICE_ID_ALTIMA_AC1003	0x03eb
>>  +#define PCI_VENDOR_ID_LENOVO		0x17aa
>> +
>>  #define PCI_VENDOR_ID_ARECA		0x17d3
>>  #define PCI_DEVICE_ID_ARECA_1110	0x1110
>
> Not sure why I'm CC'd :)  But of course I have an opinion :)  Usually we 
> don't add these IDs until a driver is actually using them.  Just add it in 
> the patch that starts using it in thinkpad-acpi.

Very well.  I don't usually merge stuff that goes to different subsystems,
but since you implicitly ACK'd it... :-)

I will merge this patch with the next one in the series :)

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux