On Fri, 2007-06-29 at 15:23 +0200, Patrick McHardy wrote: > I'm not sure that "the only sensible thing to do" is right, we > do allow dynamic registration of netlink families and do the > module reference thing anyway (admittedly, I never liked that > and the autoloading part very much). I guess it depends on how > this will be used in the end, if you really do have a group per > device or something like that you probably need to be able to > unregister at any time. But as I said previously I believe its > more in the spirit of netlink to group things logically by > message type, in which case some core part would own the > family and not a single device. > > If you do want the dynamic unregistation *and* the non-root mc > listening then I guess you don't have a choice but to unbind > sockets at unregistration. That shouln't be a real problem, > without having though much about it, I believe just clearing > the mc group from the bitmap and calling netlink_update_subscriptions > should be fine. Yeah, true, but the patch gets larger with every little thing here :) How about for now I only allow dynamic registration (no unregistration) and just send out when new groups are registered, and also give userspace a list of registered mc groups when they ask for a family description? That should make this patch not too big and still leaves room for dynamic unregistration later. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
