On Mon, 2007-06-25 at 22:49 +0200, Bartók Albert wrote: > GMail On 16/06/07, Dmitry Torokhov <dtor@xxxxxxxxxxxxx> wrote: > > On Saturday 16 June 2007 13:11, Richard Hughes wrote: > > > On Fri, 2007-06-15 at 15:53 +0100, Richard Hughes wrote: > > > > On Fri, 2007-06-15 at 10:29 -0400, Dmitry Torokhov wrote: > > > > > On 6/15/07, Richard Hughes <hughsient@xxxxxxxxx> wrote: > > > > > > On Fri, 2007-06-15 at 13:29 +0100, Richard Hughes wrote: > > > > > > > in response to an event, but I'm thinking in a resume hook we should > > > > > > > probably do acpi_evaluate_integer(handle, "_LID", NULL, &state) and then > > > > > > > send an event, just so userspace is aware of what the state of the panel > > > > > > > is. > > > > > > > > > > > > Attached patch fixed the issue for me. Comments? > > > > > > > > > > > > > > > > The patch makes perfect sense. The only issue I have is this: > > > > > > > > > > > + /* on resume we send the state; it might be the same, but userspace > > > > > > + * should handle duplicated events */ > > > > > > > > > > If switch state matches to what input layer thinks it is the event > > > > > will not even reach userspace. > > > > > > > > Okay, new patch attached, thanks for the speedy review. > > > > > > This fix is also confirmed by somebody else, see > > > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243030 > > > > > > It would be great if this could go into .22, although I appreciate it's > > > quite late in the day. > > > > > > > This is of course Len's call but in my book this is a bugfix and as such > > is appropriate for -rc4/rc5. > > > Guys? Any ack-nak? > > works perfectly for me so far. Thanks. Len, can you add this to your tree please. Thanks. Richard. - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
