On Tue, Jun 19, 2007 at 09:57:44PM -0300, Henrique de Moraes Holschuh wrote: > On Wed, 20 Jun 2007, Andreas Herrmann wrote: > > Fix kernel build problem: > > > > thinkpad_acpi.c:(.text+0x7486a): undefined reference to `ec_write' > > > > (as THINKPAD_ACPI depends on ACPI_EC) > > > > Signed-off-by: Andreas Herrmann <andreas.herrmann3@xxxxxxx> > > --- > > drivers/misc/Kconfig | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig > > index 2f2fbff..72774c9 100644 > > --- a/drivers/misc/Kconfig > > +++ b/drivers/misc/Kconfig > > @@ -139,6 +139,7 @@ config SONYPI_COMPAT > > config THINKPAD_ACPI > > tristate "ThinkPad ACPI Laptop Extras" > > depends on X86 && ACPI > > + select ACPI_EC > > select BACKLIGHT_CLASS_DEVICE > > select HWMON > > ---help--- > > Acked-by: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx> > Well, this one shouldn't be applied. The problem is better fixed in arch/x86_64/Kconfig. BTW, the above patch would lead to kconfig warnings on non x86-architectures. A proper version would be to add "select ACPI_EC if X86". Regards, Andreas -- Operating | AMD Saxony Limited Liability Company & Co. KG, System | Wilschdorfer Landstr. 101, 01109 Dresden, Germany Research | Register Court Dresden: HRA 4896, General Partner authorized Center | to represent: AMD Saxony LLC (Wilmington, Delaware, US) (OSRC) | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
