Hi, On Thursday, 21 June 2007 15:03, Pavel Machek wrote: > Hi! > > > > > > Not. Could pm_message_t have a member indicating the suspend state? > > > > > > > > Well, I thought about that, but I did't know what people on linux-pm would > > > > think about that. > > > > > > Let's get rid of pm_message_t entirely. Didn't we already discuss > > > how the main reasons for it will vanish if drivers get new PM methods? > > > > > > > > > > Alternatively, we could introduce a pm_target() global PM operation that will > > > > set the target sleep state for the entire system. > > > > > > I hope you mean "get the target state"!! > > > > > > If drivers actually need a handle on that state, that'd be a fair > > > approach; make it an opaque type though, platform-specific. > > > > > > But actually I don't see much point to having such a struct. What > > > matters is the attributes of the target state (what resources will > > > be present, especially), and that rarely needs to be indicated by > > > any kind of cookie. Consider the "current" task ... it's implicit, > > > always present (except in IRQ contexts), and hardly ever accessed > > > despite being more fundamental than "target PM state". > > > > The issue at hand is that some device drivers may need to know what the > > target sleep state of the system will be when their .suspend() routines are > > being executed. Currently, there's no means of passing that information to the > > drivers and my question is how to do this. > > > > IMO it can be done in two different ways: > > 1) via a .suspend() argument > > 2) via a global variable that the drivers can read. > > Just do 1). Global variables are ugly, and we already have space in > pm_message_t. Well, this is what Len voted for, I think. David is against it. I also think that the cleanest way would be to pass that as an argument to .suspend(), but currently pm_message_t. is passed by value and if we made it a real struct (ie. with more than one field), that would also become ugly, IMHO. So, can we make pm_message_t consist only of the target state? Greetings, Rafael -- "Premature optimization is the root of all evil." - Donald Knuth - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
