Applied. thanks Myron! -Len On Monday 04 June 2007 18:25, Myron Stowe wrote: > >From : Myron Stowe <myron.stowe@xxxxxx> > > I believe there is an issue with the new 'package' argument type support > just submitted upstream. > > In the routine acpi_ut_create_package_object(), if the > ACPI_ALLOCATE_ZEROED() fails then ACPI_FREE(package_desc) is called as > part of the cleanup. This should instead be > acpi_ut_remove_reference(package_desc) in order to remove the reference > acquired from acpi_ut_create_internal_object() [see the routine > acpi_ut_create_buffer_object() as an example of proper functionality]. > > This patch is against the Linux-ized ACPI CA, since I don't have a good > way to modify or test the original Intel version. I hope it's small > enough that you can easily make the corresponding change to the Intel > version. > > This modification may be used under either the GPL or the BSD-style > license used for the Intel ACPI CA. > > Signed-off-by: Myron Stowe < myron.stowe@xxxxxx> > > --- a/drivers/acpi/utilities/utobject.c 2007-06-04 15:49:19.000000000 -0600 > +++ b/drivers/acpi/utilities/utobject.c 2007-06-04 15:52:17.000000000 -0600 > @@ -177,7 +177,7 @@ > package_elements = ACPI_ALLOCATE_ZEROED((acpi_size) > (count + 1) * sizeof(void *)); > if (!package_elements) { > - ACPI_FREE(package_desc); > + acpi_ut_remove_reference(package_desc); > return_PTR(NULL); > } > - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html